Skip to content

ref(snapshots): Track diff algorithm version on comparison results#112729

Merged
NicoHinderling merged 1 commit intomasterfrom
04-10-ref_snapshots_track_diff_algorithm_version_on_comparison_results
Apr 10, 2026
Merged

ref(snapshots): Track diff algorithm version on comparison results#112729
NicoHinderling merged 1 commit intomasterfrom
04-10-ref_snapshots_track_diff_algorithm_version_on_comparison_results

Conversation

@NicoHinderling
Copy link
Copy Markdown
Contributor

@NicoHinderling NicoHinderling commented Apr 10, 2026

Summary

  • Store diff_algorithm_version in the comparison's extras JSON field so we can track which version of the diffing logic produced each result
  • Add DIFF_ALGORITHM_VERSION = 1 constant in compare.py — bump this when diffing logic changes in a way that could affect results
  • No DB migration needed since it uses the existing extras JSONField

Test plan

  • No behavioral change — just records metadata on comparison rows

Copy link
Copy Markdown
Contributor Author

NicoHinderling commented Apr 10, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2026
@NicoHinderling NicoHinderling marked this pull request as ready for review April 10, 2026 19:53
@NicoHinderling NicoHinderling requested a review from a team as a code owner April 10, 2026 19:53
@NicoHinderling NicoHinderling force-pushed the 04-10-ref_snapshots_track_diff_algorithm_version_on_comparison_results branch from 7f86eb4 to f775043 Compare April 10, 2026 21:19
@NicoHinderling NicoHinderling force-pushed the 04-10-ref_snapshots_add_configurable_diff_threshold_for_snapshot_comparison branch from 2a40e7f to df7a12d Compare April 10, 2026 21:19
@NicoHinderling NicoHinderling force-pushed the 04-10-ref_snapshots_track_diff_algorithm_version_on_comparison_results branch from f775043 to 6dcd89c Compare April 10, 2026 21:30
@NicoHinderling NicoHinderling force-pushed the 04-10-ref_snapshots_add_configurable_diff_threshold_for_snapshot_comparison branch from df7a12d to 418c4ee Compare April 10, 2026 21:30
Base automatically changed from 04-10-ref_snapshots_add_configurable_diff_threshold_for_snapshot_comparison to master April 10, 2026 21:52
@NicoHinderling NicoHinderling force-pushed the 04-10-ref_snapshots_track_diff_algorithm_version_on_comparison_results branch from 6dcd89c to a111e2c Compare April 10, 2026 21:56
@NicoHinderling NicoHinderling merged commit 3e22506 into master Apr 10, 2026
57 checks passed
@NicoHinderling NicoHinderling deleted the 04-10-ref_snapshots_track_diff_algorithm_version_on_comparison_results branch April 10, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants